flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4730) Introduce CheckpointMetaData
Date Thu, 06 Oct 2016 12:09:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551765#comment-15551765
] 

ASF GitHub Bot commented on FLINK-4730:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2583#discussion_r82173079
  
    --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
    @@ -127,12 +125,7 @@
     	 */
     	public FlinkKafkaConsumerBase(List<String> topics, KeyedDeserializationSchema<T>
deserializer) {
     		this.topics = checkNotNull(topics);
    -		checkArgument(topics.size() > 0, "You have to define at least one topic.");
    --- End diff --
    
    +1 to pass a dummy list if possible


> Introduce CheckpointMetaData
> ----------------------------
>
>                 Key: FLINK-4730
>                 URL: https://issues.apache.org/jira/browse/FLINK-4730
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>
> Currently, the meta data for each checkpoint consists of up to 5 long values which are
passed through several functions. When adding/removing meta data  we would have to change
function signatures in many places. Furthermore, this is prone to errors when the order of
arguments is changed accidentally. We should introduce a CheckpointMetaData which encapsulates
this checkpoint meta data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message