flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4746) Replace TaskManagerRuntimeInfo by TaskManagerConfiguration
Date Tue, 11 Oct 2016 10:35:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565115#comment-15565115
] 

ASF GitHub Bot commented on FLINK-4746:
---------------------------------------

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/2599
  
    Rebasing this PR. If Travis gives green light, then I'll merge the PR.


> Replace TaskManagerRuntimeInfo by TaskManagerConfiguration
> ----------------------------------------------------------
>
>                 Key: FLINK-4746
>                 URL: https://issues.apache.org/jira/browse/FLINK-4746
>             Project: Flink
>          Issue Type: Sub-task
>          Components: TaskManager
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>
> The {{TaskExecutor}} creates an additional {{TaskManagerRuntimeInfo}} when created. It
contains information which is already contained in the {{TaskManagerConfiguration}} object.
We should replace this object because it stores redundant information. Furthermore, it makes
testing the {{TaskExecutor}} more difficult, since mocking the {{TaskManagerConfiguration}}
will cause a failure when trying to create the {{TaskManagerRuntimeInformation}} from the
{{TaskManagerConfiguration}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message