flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4753) Kafka 0.8 connector's Periodic Offset Committer should synchronize on checkpoint lock
Date Mon, 10 Oct 2016 09:42:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561814#comment-15561814
] 

ASF GitHub Bot commented on FLINK-4753:
---------------------------------------

Github user rmetzger commented on the issue:

    https://github.com/apache/flink/pull/2604
  
    Why do you want to synchronize on the checkpoint lock when creating the copy?
    The `PeriodicOffsetCommitter` doesn't provide any reliability guarantees anyways, so synchronizing
doesn't add any additional correctness.


> Kafka 0.8 connector's Periodic Offset Committer should synchronize on checkpoint lock
> -------------------------------------------------------------------------------------
>
>                 Key: FLINK-4753
>                 URL: https://issues.apache.org/jira/browse/FLINK-4753
>             Project: Flink
>          Issue Type: Bug
>          Components: Kafka Connector
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>             Fix For: 1.2.0
>
>
> The {{PeriodicOffsetCommitter}} doesn't synchronize on the checkpoint lock when creating
a copy of the partition offsets in the current state.
> I propose to pass the checkpoint lock into{{PeriodicOffsetCommitter}}, and  let {{PeriodicOffsetCommitter}}
use {{Kafka08Fetcher#snapshotCurrentState()}} to make the current state copy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message