flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chesnay Schepler (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (FLINK-4772) Store metrics in MetricStore as strings
Date Fri, 21 Oct 2016 11:59:58 GMT

     [ https://issues.apache.org/jira/browse/FLINK-4772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chesnay Schepler closed FLINK-4772.
-----------------------------------
    Resolution: Fixed

Implemented in e30e7a6192d921d7a3c94beb178eb2c7b9ba74c0

> Store metrics in MetricStore as strings
> ---------------------------------------
>
>                 Key: FLINK-4772
>                 URL: https://issues.apache.org/jira/browse/FLINK-4772
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics, Webfrontend
>    Affects Versions: 1.1.2
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.2.0
>
>
> The MetricStore is a nested structure which stores metrics in several Map<String,
Object> objects. The key is the name of the metric, while the value is the value of the
metric. Since gauges are transmitted as Strings, and all other metric types are of numeric
nature, the type of the value is limited to Strings and Numbers.
> Storing them with different types however has no benefit, and makes working with the
MetricStore needlessly complicated since one is forced to cast every retrieved metric. This
also implies that one either has to know what kind of metric you're dealing with (which can
easily go wrong), or check the type before using the metric, which is cumbersome.
> As such i propose storing all metrics as strings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message