flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4851) Add FatalErrorHandler and MetricRegistry to ResourceManager
Date Fri, 21 Oct 2016 15:53:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15595485#comment-15595485
] 

ASF GitHub Bot commented on FLINK-4851:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2655#discussion_r84506385
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/ResourceManagerJobMasterTest.java
---
    @@ -145,6 +171,10 @@ public void testRegisterJobMasterWithFailureLeaderListener() throws
Exception {
     		Future<RegistrationResponse> declineFuture = resourceManager.registerJobMaster(rmLeaderSessionId,
jmLeaderSessionId, jobMasterAddress, unknownJobIDToHAServices);
     		RegistrationResponse response = declineFuture.get(5, TimeUnit.SECONDS);
     		assertTrue(response instanceof RegistrationResponse.Decline);
    +
    +		if (testingFatalErrorHandler.hasExceptionOccurred()) {
    +			testingFatalErrorHandler.rethrowError();
    +		}
    --- End diff --
    
    This seems like a lot of boilerplate that we could abstract using a base testing class
for ResourceManager tests.


> Add FatalErrorHandler and MetricRegistry to ResourceManager
> -----------------------------------------------------------
>
>                 Key: FLINK-4851
>                 URL: https://issues.apache.org/jira/browse/FLINK-4851
>             Project: Flink
>          Issue Type: Sub-task
>          Components: ResourceManager
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>
> The {{ResourceManager}} currently does not contain a {{FatalErrorHandler}}. In order
to harmonize the fatal error handling across all components, we should introduce a {{FatalErrorHandler}},
which handles fatal errors. Additionally, we should also give a {{MetricRegistry}} to the
{{ResourceManager}} so that it can report metrics.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message