flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4857) ZooKeeperUtils have a throws exception clause without throwing exceptions
Date Wed, 19 Oct 2016 12:26:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588620#comment-15588620
] 

ASF GitHub Bot commented on FLINK-4857:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/2659

    [FLINK-4857] Remove throws clause from ZooKeeperUtils functions

    Remove the unnecessary throws clauses from all ZooKeeperUtils' functions which don't
    throw an actual exception.
    
    Removing the exceptions will allow to properly implement the `HighAvailabilityServices`
in the Flip-6 branch. We could apply this PR also directly to the feature branch if we don't
want to rebase it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink removeExceptionsZooKeeperUtils

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2659.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2659
    
----
commit 11929e9817c693d74e295f777e66025189526689
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2016-10-19T12:23:47Z

    [FLINK-4857] Remove throws clause from ZooKeeperUtils functions
    
    Remove the unnecessary throws clauses from all ZooKeeperUtils' functions which don't
    throw an actual exception.

----


> ZooKeeperUtils have a throws exception clause without throwing exceptions
> -------------------------------------------------------------------------
>
>                 Key: FLINK-4857
>                 URL: https://issues.apache.org/jira/browse/FLINK-4857
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>
> Flink's {{ZooKeeperUtils}} contains functions which have a throws clause even though
they don't throw an {{Exception}}. This is wrong and should be fixed by removing the throw
clauses.
> Changing the ZooKeeperUtils will help to properly implement the {{HighAvailabilityServices}}
in the flip-6 branch, because the high availability service methods don't have to throw exceptions
then.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message