flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4857) ZooKeeperUtils have a throws exception clause without throwing exceptions
Date Wed, 19 Oct 2016 16:24:59 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589164#comment-15589164
] 

ASF GitHub Bot commented on FLINK-4857:
---------------------------------------

Github user mxm commented on the issue:

    https://github.com/apache/flink/pull/2659
  
    +1 LGTM


> ZooKeeperUtils have a throws exception clause without throwing exceptions
> -------------------------------------------------------------------------
>
>                 Key: FLINK-4857
>                 URL: https://issues.apache.org/jira/browse/FLINK-4857
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>
> Flink's {{ZooKeeperUtils}} contains functions which have a throws clause even though
they don't throw an {{Exception}}. This is wrong and should be fixed by removing the throw
clauses.
> Changing the ZooKeeperUtils will help to properly implement the {{HighAvailabilityServices}}
in the flip-6 branch, because the high availability service methods don't have to throw exceptions
then.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message