flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4864) Shade Calcite dependency in flink-table
Date Fri, 21 Oct 2016 05:55:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15594176#comment-15594176
] 

ASF GitHub Bot commented on FLINK-4864:
---------------------------------------

GitHub user wuchong opened a pull request:

    https://github.com/apache/flink/pull/2673

    [FLINK-4864] [table] Shade Calcite dependency in flink-table

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    
    This can solve version conflicts when users have a own Calcite dependency in the classpath.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wuchong/flink shade-calcite-FLINK-4864

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2673.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2673
    
----
commit 61d6c80789cce00f47c04df1e97ed0ea016fcbb3
Author: Jark Wu <wuchong.wc@alibaba-inc.com>
Date:   2016-10-21T05:50:21Z

    [FLINK-4864] [table] Shade Calcite dependency in flink-table

----


> Shade Calcite dependency in flink-table
> ---------------------------------------
>
>                 Key: FLINK-4864
>                 URL: https://issues.apache.org/jira/browse/FLINK-4864
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Fabian Hueske
>            Assignee: Jark Wu
>
> The Table API has a dependency on Apache Calcite.
> A user reported to have version conflicts when having a own Calcite dependency in the
classpath.
> The solution would be to shade away the Calcite dependency (Calcite's transitive dependencies
are already shaded).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message