flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4866) Make Trigger.clear() Abstract to Enforce Implementation
Date Fri, 21 Oct 2016 05:54:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15594169#comment-15594169
] 

ASF GitHub Bot commented on FLINK-4866:
---------------------------------------

GitHub user wuchong opened a pull request:

    https://github.com/apache/flink/pull/2672

    [FLINK-4866] [streaming] Make Trigger.clear() Abstract to Enforce Implementation

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    This PR makes Trigger.clear() method to be abstract, so that implementors of custom triggers
will not forget to clean up their state/timers properly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wuchong/flink trigger-FLINK-4866

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2672.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2672
    
----
commit 313b2a6f1871357b3281e623423f49ef84ad59a1
Author: Jark Wu <wuchong.wc@alibaba-inc.com>
Date:   2016-10-21T05:46:45Z

    [FLINK-4866] [streaming] Make Trigger.clear() Abstract to Enforce Implementation

----


> Make Trigger.clear() Abstract to Enforce Implementation
> -------------------------------------------------------
>
>                 Key: FLINK-4866
>                 URL: https://issues.apache.org/jira/browse/FLINK-4866
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>            Assignee: Jark Wu
>
> If the method is not abstract implementors of custom triggers will not realise that it
could be necessary and they will likely not clean up their state/timers properly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message