flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4879) class KafkaTableSource should be public just like KafkaTableSink
Date Fri, 21 Oct 2016 10:01:06 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15594687#comment-15594687
] 

ASF GitHub Bot commented on FLINK-4879:
---------------------------------------

GitHub user hzyuemeng1 opened a pull request:

    https://github.com/apache/flink/pull/2678

    [FLINK-4879] [Kafka-Connector] class KafkaTableSource should be public just like KafkaTableSink

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hzyuemeng1/flink KafkaTableSource_should_public

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2678.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2678
    
----
commit 9d2d18c5e32e4e89d9482b6b6e70c4891f551109
Author: hzyuemeng1 <hzyuemeng1@corp.netease.com>
Date:   2016-10-21T09:27:12Z

    class KafkaTableSource should be public

----


> class KafkaTableSource should be public just like KafkaTableSink
> ----------------------------------------------------------------
>
>                 Key: FLINK-4879
>                 URL: https://issues.apache.org/jira/browse/FLINK-4879
>             Project: Flink
>          Issue Type: Bug
>          Components: Kafka Connector
>    Affects Versions: 1.1.1, 1.1.3
>            Reporter: yuemeng
>            Priority: Minor
>             Fix For: 1.1.4
>
>         Attachments: 0001-class-KafkaTableSource-should-be-public.patch
>
>
> *class KafkaTableSource should be public just like KafkaTableSink,by default,it's modifier
is default ,and we cann't access out of it's package*,
> for example:
>  {code}
> def createKafkaTableSource(
>       topic: String,
>       properties: Properties,
>       deserializationSchema: DeserializationSchema[Row],
>       fieldsNames: Array[String],
>       typeInfo: Array[TypeInformation[_]]): KafkaTableSource = {
>     if (deserializationSchema != null) {
>       new Kafka09TableSource(topic, properties, deserializationSchema, fieldsNames, typeInfo)
>     } else {
>       new Kafka09JsonTableSource(topic, properties, fieldsNames, typeInfo)
>     }
>   }
> {code}
> Because of the class KafkaTableSource modifier is default,we cann't define this function
result type with KafkaTableSource ,we must give the specific type.
> if some other kafka source extends KafkaTableSource ,and we don't sure which subclass
of KafkaTableSource should be use,how can we specific the type?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message