flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4879) class KafkaTableSource should be public just like KafkaTableSink
Date Fri, 21 Oct 2016 10:54:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15594785#comment-15594785
] 

ASF GitHub Bot commented on FLINK-4879:
---------------------------------------

Github user rmetzger commented on the issue:

    https://github.com/apache/flink/pull/2678
  
    Thank you for opening a pull request.
    
    @fhueske @twalthr @uce I think its okay to make the class public, in case users want to
use a custom Kafka consumer, right?


> class KafkaTableSource should be public just like KafkaTableSink
> ----------------------------------------------------------------
>
>                 Key: FLINK-4879
>                 URL: https://issues.apache.org/jira/browse/FLINK-4879
>             Project: Flink
>          Issue Type: Bug
>          Components: Kafka Connector, Table API & SQL
>    Affects Versions: 1.1.1, 1.1.3
>            Reporter: yuemeng
>            Priority: Minor
>             Fix For: 1.1.4
>
>         Attachments: 0001-class-KafkaTableSource-should-be-public.patch
>
>
> *class KafkaTableSource should be public just like KafkaTableSink,by default,it's modifier
is default ,and we cann't access out of it's package*,
> for example:
>  {code}
> def createKafkaTableSource(
>       topic: String,
>       properties: Properties,
>       deserializationSchema: DeserializationSchema[Row],
>       fieldsNames: Array[String],
>       typeInfo: Array[TypeInformation[_]]): KafkaTableSource = {
>     if (deserializationSchema != null) {
>       new Kafka09TableSource(topic, properties, deserializationSchema, fieldsNames, typeInfo)
>     } else {
>       new Kafka09JsonTableSource(topic, properties, fieldsNames, typeInfo)
>     }
>   }
> {code}
> Because of the class KafkaTableSource modifier is default,we cann't define this function
result type with KafkaTableSource ,we must give the specific type.
> if some other kafka source extends KafkaTableSource ,and we don't sure which subclass
of KafkaTableSource should be use,how can we specific the type?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message