flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4923) Expose input/output buffers and bufferPool usage as a metric for a Task
Date Thu, 27 Oct 2016 12:05:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611676#comment-15611676
] 

ASF GitHub Bot commented on FLINK-4923:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2693#discussion_r85322207
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
    @@ -347,6 +348,12 @@ public Task(
     
     		// finally, create the executing thread, but do not start it
     		executingThread = new Thread(TASK_THREADS_GROUP, this, taskNameWithSubtask);
    +
    +		// add metrics for buffers
    +		this.metrics.getIOMetricGroup().getBuffersGroup().gauge("inputQueueLength", new TaskIOMetricGroup.InputBuffersGauge(this));
    --- End diff --
    
    I have rebased merged this already.
    How about doing that in a followup patch?


> Expose input/output buffers and bufferPool usage as a metric for a Task
> -----------------------------------------------------------------------
>
>                 Key: FLINK-4923
>                 URL: https://issues.apache.org/jira/browse/FLINK-4923
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>            Reporter: zhuhaifeng
>            Assignee: zhuhaifeng
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> We should expose the following Metrics on the TaskIOMetricGroup:
>  1. Buffers.inputQueueLength: received buffers of InputGates for a task
>  2. Buffers.outputQueueLength: buffers of produced ResultPartitions for a task
>  3. Buffers.inPoolUsage: usage of InputGates buffer pool for a task
>  4. Buffers.outPoolUsage: usage of produced ResultPartitions buffer pool for a task



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message