flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #2580: [FLINK-4723] [kafka-connector] Unify committed off...
Date Mon, 03 Oct 2016 12:46:28 GMT
GitHub user tzulitai opened a pull request:

    https://github.com/apache/flink/pull/2580

    [FLINK-4723] [kafka-connector] Unify committed offsets to Kafka to be the next record
to process

    The description within the JIRA ticket ([FLINK-4723](https://issues.apache.org/jira/browse/FLINK-4723))
explains the reasoning for this change.
    
    With this change, offsets committed to Kafka are larger by 1 compared to the internally
checkpointed offsets. This is changed at the `FlinkKafkaConsumerBase` level, so that offsets
given through the abstract `commitSpecificOffsetsToKafka()` method to the version-specific
implementations are already incremented and represent the next record to process. This way,
the version-specific implementations simply commit the given offsets without the need to manipulate
them.
    
    This PR also includes major refactoring of the IT tests to add commit offset related IT
tests to `FlinkKafkaConsumerTestBase`, and let both the 0.8 and 0.9 consumers run offset committing
/ initial offset startup tests (previously only the 0.8 consumer had these tests).
    
    R: @rmetzger what's your take on this?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzulitai/flink FLINK-4723

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2580.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2580
    
----
commit cc782ffd4c174f23c45349771b318a08a2be75a3
Author: Tzu-Li (Gordon) Tai <tzulitai@apache.org>
Date:   2016-10-02T08:54:57Z

    [FLINK-4723] [kafka-connector] Unify committed offsets to Kafka to be next record to process

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message