flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request #2622: [FLINK-3706] Fix YARN test instability
Date Tue, 11 Oct 2016 13:55:56 GMT
GitHub user rmetzger opened a pull request:

    https://github.com/apache/flink/pull/2622

    [FLINK-3706] Fix YARN test instability

    The most important change in this commit is that the `YarnTestBase.Runner` doesn't do
`try {} catch (Throwable t) { fail(t); }` anymore, which doesn't lead to a test failure, because
its called outside the main thread.
    With the change, all throwables are reported back to the main thread and fail the test
there properly (many YARN tests benefit from this change).
    
    @mxm could you quickly review the changes? The change is rather small, I was considering
to push a hotfix, but decided to do a quick PR review round.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rmetzger/flink flink3706

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2622.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2622
    
----
commit 7a978a57e4f5845660cff386eb629193dab44109
Author: Robert Metzger <rmetzger@apache.org>
Date:   2016-10-10T15:04:16Z

    [FLINK-3706] Fix YARN test instability
    
    The most important change in this commit is that the `YarnTestBase.Runner` doesn't do
"try {} catch (Throwable t) { fail(t); }" anymore, which doesn't lead to a test failure, because
its called outside the main thread.
    With the change, all throwables are reported back to the main thread and fail the test
there properly (many YARN tests benefit from this change).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message