flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request #2627: Kafka 0.10 follow-up fixes
Date Wed, 12 Oct 2016 15:34:48 GMT
GitHub user rmetzger opened a pull request:

    https://github.com/apache/flink/pull/2627

    Kafka 0.10 follow-up fixes

    After merging https://github.com/apache/flink/pull/2369, there was some follow-up feedback
in the final commit: https://github.com/apache/flink/commit/6731ec1e48d0a0092dd2330adda73bcf37fda8d7#commitcomment-19375265,
which I'm addressing with this pull request:
    
    - I'm adding a `Kafka010FetcherTest`, which is based on the `Kafka09FetcherTest`.
    - I'm undoing the changes in `DataGenerators` to avoid starting a full Flink job to produce
some data into a topic.
    - I'm removing some commented-out code that has been part of the Kafka code for a while.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rmetzger/flink kafka_inline_producer

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2627.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2627
    
----
commit 744f8ebb66b2a7288942be139cd7a7e6d1170c80
Author: Robert Metzger <rmetzger@apache.org>
Date:   2016-10-11T13:48:32Z

    [hotfix][kafka] Undo DataGenerators changes (use inline kafka producer again

commit ce26248ad0a4672eeb556863a061a478987694e9
Author: Robert Metzger <rmetzger@apache.org>
Date:   2016-10-12T12:03:01Z

    [hotfix][kafka] Backport Kafka09FetcherTest for Kafka010

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message