flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #2723: [FLINK-3617] Simple fix for OptionSerializer.
Date Tue, 01 Nov 2016 19:12:30 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2723
  
    -1 to merging this, for the reason that this removes alters unrelated tests by removing
lines.
    
    I think that calling `toString()` was introduced as a way to test if the copies made by
serializers seem to valid (the method accesses many fields), or if the cloning (involving
possibly unsafe instantiations and field/memory accesses) broke something. It may not be a
thorough test, but at least it tests parts.
    
    Please, never, never change test cases!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message