flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #2723: [FLINK-3617] Simple fix for OptionSerializer.
Date Tue, 01 Nov 2016 19:47:57 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2723
  
    Yes, deepEquals() is a nice way to do this (and could be added to the tests).
    
    Still, no pull requests should ever change (especially weaken) any unrelated tests. We
need to enforce that policy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message