flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tonycox <...@git.apache.org>
Subject [GitHub] flink pull request #2686: [FLINK-4743] The sqrt/power function not accept th...
Date Wed, 02 Nov 2016 10:14:34 GMT
Github user tonycox commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/api/table/functions/utils/MathFunctions.java
    @@ -0,0 +1,29 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.api.table.functions.utils;
    +import java.math.BigDecimal;
    +public class MathFunctions {
    +	public static double power(double a, BigDecimal b) {
    +		return Math.pow(a, b.doubleValue());
    +	}
    --- End diff --
    Why I didn't write `power` function in scala class.
    I plunged into a problem with static access to method. I tried rewrite `MathFunctions.java`
into Scala object https://goo.gl/rmLy8f . 
    In BuiltInMethods we cannot to use `classOf[]` with scala `object`. So I used `getClass()`
    Test throws [exception](http://pastebin.com/fLNr4CfX) 
    because `getClass()` doesn't return `MathFunctions` itself, it returns `MathFunctions$`
    **But** there is a solving :)
    val POWER_DEC =
        "power", classOf[Double], classOf[JBigDecimal])
    I prefer java approach, what do you think @wuchong @fhueske ?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message