flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2732: [FLINK-4272] Create a JobClient for job control an...
Date Wed, 09 Nov 2016 13:50:00 GMT
Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorErrorITCase.java
    @@ -91,11 +91,9 @@ public void testFaultyAccumulator() throws Exception {
     		try {
     			fail("Should have failed.");
    -		} catch (ProgramInvocationException e) {
    -			Assert.assertTrue("Exception should be passed:",
    -					e.getCause() instanceof JobExecutionException);
    +		} catch (JobExecutionException e) {
    --- End diff --
    Aren't we changing the API by no longer throwing a `ProgramInvocationException` and instead
throwing a `JobExecutionException`? I thought that thrown exceptions are part of the defined

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message