flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cresny <...@git.apache.org>
Subject [GitHub] flink issue #2288: Feature/s3 a fix
Date Wed, 09 Nov 2016 20:55:20 GMT
Github user cresny commented on the issue:

    https://github.com/apache/flink/pull/2288
  
    @uce I finally got around to fixing this. Regarding your above comments:
    
    - I think we got the "flattening" concern backwards. What I meant and wanted to avoid
was to move all files into single directory. The calling code asks to simply upload the lib
dir, and I think it should be copied structurally intact. I think I saw on the user list a
complaint that properties files were not moved -- this should fix that. Or am I missing some
other concern?
    
    - The new commit 26c8511701d6b852a3c6f8b306f4b5da8e7b8479 now only modifies flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
    
    - I kept the check for file:// scheme for now just because I think it's safer to check
than assume it's set down the call stack but I can hunt down and change those calls if you
think it's best. 
    
    Since this PR is pretty tortured, maybe I should create a new one with just the above
commit?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message