flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gaborhermann <...@git.apache.org>
Subject [GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...
Date Thu, 10 Nov 2016 09:13:21 GMT
Github user gaborhermann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2542#discussion_r87353990
  
    --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala
---
    @@ -273,6 +308,14 @@ object ALS {
         val defaultValue: Option[Int] = Some(10)
       }
     
    +  case object ImplicitPrefs extends Parameter[Boolean] {
    --- End diff --
    
    I also changed this, but note that this is for the explicit ALS algorithm too. Do you
think it's okay to give this recommendation for explicit case too? Really high number of factors
(without regularization) might lead to overfitting.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message