flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #2822: [FLINK-5075] [kinesis] Make Kinesis consumer fail-...
Date Tue, 22 Nov 2016 13:55:59 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2822#discussion_r89119126
  
    --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
    @@ -283,7 +285,7 @@ public String getShardIterator(KinesisStreamShard shard, String shardIteratorTyp
     	 * @param startShardId which shard to start with for this describe operation (earlier
shard's infos will not appear in result)
     	 * @return the result of the describe stream operation
     	 */
    -	private DescribeStreamResult describeStream(String streamName, String startShardId)
throws InterruptedException {
    +	private DescribeStreamResult describeStream(String streamName, @Nullable String startShardId)
throws InterruptedException {
    --- End diff --
    
    Only Kinesis does. Kinesalite incorrectly ignores `startShardId`.
    It's marked `Nullable` here, because on fresh startups this method will be called with
a `null` as the start ID (on startup there will be no shard Id to start from).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message