flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2732: [FLINK-4272] Create a JobClient for job control an...
Date Tue, 22 Nov 2016 15:12:20 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2732#discussion_r89135481
  
    --- Diff: flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorErrorITCase.java
---
    @@ -91,11 +91,9 @@ public void testFaultyAccumulator() throws Exception {
     		try {
     			env.execute();
     			fail("Should have failed.");
    -		} catch (ProgramInvocationException e) {
    -			Assert.assertTrue("Exception should be passed:",
    -					e.getCause() instanceof JobExecutionException);
    +		} catch (JobExecutionException e) {
    --- End diff --
    
    `ProgramInvocationException` are thrown during execution of the user program. `JobExecutionException`
is thrown while the job is executing. That makes much more sense IMHO. The API doesn't strictly
define any exceptions (`throws Exception`). Thus, we're not breaking.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message