flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3551) Sync Scala and Java Streaming Examples
Date Thu, 24 Nov 2016 10:40:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692925#comment-15692925
] 

ASF GitHub Bot commented on FLINK-3551:
---------------------------------------

Github user thvasilo commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2761#discussion_r89471075
  
    --- Diff: flink-examples/flink-examples-streaming/src/main/scala/org/apache/flink/streaming/scala/examples/windowing/GroupedProcessingTimeWindowExample.scala
---
    @@ -0,0 +1,80 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.scala.examples.windowing
    +
    +import java.util.concurrent.TimeUnit.MILLISECONDS
    +
    +import org.apache.flink.api.scala._
    +import org.apache.flink.streaming.api.functions.sink.SinkFunction
    +import org.apache.flink.streaming.api.functions.source.RichParallelSourceFunction
    +import org.apache.flink.streaming.api.functions.source.SourceFunction.SourceContext
    +import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment
    +import org.apache.flink.streaming.api.windowing.time.Time
    +
    +object GroupedProcessingTimeWindowExample {
    --- End diff --
    
    Some docstring similar to what the other examples have would be very useful here, same
for the Java code that is missing it.


> Sync Scala and Java Streaming Examples
> --------------------------------------
>
>                 Key: FLINK-3551
>                 URL: https://issues.apache.org/jira/browse/FLINK-3551
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Examples
>    Affects Versions: 1.0.0
>            Reporter: Stephan Ewen
>            Assignee: Lim Chee Hau
>             Fix For: 1.0.1
>
>
> The Scala Examples lack behind the Java Examples



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message