flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3921) StringParser not specifying encoding to use
Date Mon, 21 Nov 2016 22:47:59 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15684988#comment-15684988
] 

ASF GitHub Bot commented on FLINK-3921:
---------------------------------------

Github user rekhajoshm commented on the issue:

    https://github.com/apache/flink/pull/2060
  
    Agree @greghogan , we started this just for StringParser encoding :-)
    I am in tight schedule, however did a quick update for comments, please have a look.thank
you.
    
    - Removed unused methods on setCommentPrefix
    - Added charset functionality for user to set charset encoding on CsvReader
    - Updated test 


> StringParser not specifying encoding to use
> -------------------------------------------
>
>                 Key: FLINK-3921
>                 URL: https://issues.apache.org/jira/browse/FLINK-3921
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.3
>            Reporter: Tatu Saloranta
>            Assignee: Rekha Joshi
>            Priority: Trivial
>
> Class `flink.types.parser.StringParser` has javadocs indicating that contents are expected
to be Ascii, similar to `StringValueParser`. That makes sense, but when constructing actual
instance, no encoding is specified; on line 66 f.ex:
>    this.result = new String(bytes, startPos+1, i - startPos - 2);
> which leads to using whatever default platform encoding is. If contents really are always
Ascii (would not count on that as parser is used from CSV reader), not a big deal, but it
can lead to the usual Latin-1-VS-UTF-8 issues.
> So I think that encoding should be explicitly specified, whatever is to be used: javadocs
claim ascii, so could be "us-ascii", but could well be UTF-8 or even ISO-8859-1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message