flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3921) StringParser not specifying encoding to use
Date Tue, 29 Nov 2016 18:05:59 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706049#comment-15706049
] 

ASF GitHub Bot commented on FLINK-3921:
---------------------------------------

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/2901

    [FLINK-3921] StringParser encoding

    This further modifies #2060:
    - save charset as String which is serializable
    - remove unused methods
    - annotate new CsvReader methods as @PublicEvolving
    
    This can be squashed into the first commit after review.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 3921_stringparser_encoding

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2901.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2901
    
----

----


> StringParser not specifying encoding to use
> -------------------------------------------
>
>                 Key: FLINK-3921
>                 URL: https://issues.apache.org/jira/browse/FLINK-3921
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.3
>            Reporter: Tatu Saloranta
>            Assignee: Rekha Joshi
>            Priority: Trivial
>
> Class `flink.types.parser.StringParser` has javadocs indicating that contents are expected
to be Ascii, similar to `StringValueParser`. That makes sense, but when constructing actual
instance, no encoding is specified; on line 66 f.ex:
>    this.result = new String(bytes, startPos+1, i - startPos - 2);
> which leads to using whatever default platform encoding is. If contents really are always
Ascii (would not count on that as parser is used from CSV reader), not a big deal, but it
can lead to the usual Latin-1-VS-UTF-8 issues.
> So I think that encoding should be explicitly specified, whatever is to be used: javadocs
claim ascii, so could be "us-ascii", but could well be UTF-8 or even ISO-8859-1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message