flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4174) Enhance Window Evictor
Date Thu, 03 Nov 2016 16:46:59 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633411#comment-15633411
] 

ASF GitHub Bot commented on FLINK-4174:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2736#discussion_r86376593
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/Evictor.java
---
    @@ -18,15 +18,17 @@
     package org.apache.flink.streaming.api.windowing.evictors;
     
     import org.apache.flink.annotation.PublicEvolving;
    +import org.apache.flink.api.common.functions.RuntimeContext;
    +import org.apache.flink.metrics.MetricGroup;
     import org.apache.flink.streaming.api.windowing.windows.Window;
    -import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
    +import org.apache.flink.streaming.runtime.operators.windowing.TimestampedValue;
    +import org.apache.flink.streaming.runtime.tasks.ProcessingTimeService;
    +
     import java.io.Serializable;
     
     /**
    - * An {@code Evictor} can remove elements from a pane before it is being processed and
after
    - * window evaluation was triggered by a
    - * {@link org.apache.flink.streaming.api.windowing.triggers.Trigger}.
    - *
    + * An {@code Evictor} can remove elements from a pane before/after the evaluation of
WindowFunction and
    + * after the window evaluation gets triggered by a {@link org.apache.flink.streaming.api.windowing.triggers.Trigger}
      * <p>
    --- End diff --
    
    Missing newline before this line.


> Enhance Window Evictor
> ----------------------
>
>                 Key: FLINK-4174
>                 URL: https://issues.apache.org/jira/browse/FLINK-4174
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Streaming
>            Reporter: vishnu viswanath
>            Assignee: vishnu viswanath
>
> Enhance the current functionality of Evictor as per this [design document|https://docs.google.com/document/d/1Rr7xzlItYqvFXLyyy-Yv0vvw8f29QYAjm5i9E4A_JlU/edit].
> This includes:
> - Allow eviction of elements from the window in any order (not only from the beginning).
To do this Evictor must go through the list of elements and remove the elements that have
to be evicted instead of the current approach of : returning the count of elements to be removed
from beginning.
> - Allow eviction to be done before/after applying the window function.
> FLIP page for this enhancement : [FLIP-4|https://cwiki.apache.org/confluence/display/FLINK/FLIP-4+%3A+Enhance+Window+Evictor]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message