flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4272) Create a JobClient for job control and monitoring
Date Tue, 22 Nov 2016 15:12:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15686986#comment-15686986

ASF GitHub Bot commented on FLINK-4272:

Github user mxm commented on a diff in the pull request:

    --- Diff: flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorErrorITCase.java
    @@ -91,11 +91,9 @@ public void testFaultyAccumulator() throws Exception {
     		try {
     			fail("Should have failed.");
    -		} catch (ProgramInvocationException e) {
    -			Assert.assertTrue("Exception should be passed:",
    -					e.getCause() instanceof JobExecutionException);
    +		} catch (JobExecutionException e) {
    --- End diff --
    `ProgramInvocationException` are thrown during execution of the user program. `JobExecutionException`
is thrown while the job is executing. That makes much more sense IMHO. The API doesn't strictly
define any exceptions (`throws Exception`). Thus, we're not breaking.

> Create a JobClient for job control and monitoring 
> --------------------------------------------------
>                 Key: FLINK-4272
>                 URL: https://issues.apache.org/jira/browse/FLINK-4272
>             Project: Flink
>          Issue Type: New Feature
>          Components: Client
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: Minor
>             Fix For: 1.2.0
> The aim of this new features is to expose a client to the user which allows to cancel
a running job, retrieve accumulators for a running job, or perform other actions in the future.
Let's call it {{JobClient}} for now (although this clashes with the existing JobClient class
which could be renamed to JobClientActorUtils instead).
> The new client should be returned from the {{ClusterClient}} class upon job submission.
The client should also be instantiatable by the users to retrieve the JobClient with a JobID.
> We should expose the new JobClient to the Java and Scala APIs using a new method on the
{{ExecutionEnvironment}} / {{StreamExecutionEnvironment}} called {{executeWithControl()}}
(perhaps we can find a better name).

This message was sent by Atlassian JIRA

View raw message