flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4832) Count/Sum 0 elements
Date Mon, 28 Nov 2016 15:51:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702287#comment-15702287
] 

ASF GitHub Bot commented on FLINK-4832:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2840#discussion_r89808397
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/AggregationTest.scala
---
    @@ -0,0 +1,157 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.api.table
    +
    +import org.apache.flink.api.scala._
    +import org.apache.flink.api.scala.table._
    +import org.apache.flink.api.table.utils.TableTestBase
    +import org.apache.flink.api.table.utils.TableTestUtil._
    +import org.junit.Test
    +
    +/**
    +  * Test for testing aggregate plans.
    +  */
    +class AggregationTest extends TableTestBase {
    +
    +  @Test
    +  def testAggregateQueryBatchSQL(): Unit = {
    +    val util = batchTestUtil()
    +    util.addTable[(Int, Long, Int)]("MyTable", 'a, 'b, 'c)
    +
    +    val sqlQuery = (
    +      "SELECT avg(a),sum(b),count(c) FROM MyTable",
    --- End diff --
    
    I would separate the test into two methods.


> Count/Sum 0 elements
> --------------------
>
>                 Key: FLINK-4832
>                 URL: https://issues.apache.org/jira/browse/FLINK-4832
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Anton Mushin
>
> Currently, the Table API is unable to count or sum up 0 elements. We should improve DataSet
aggregations for this. Maybe by union the original DataSet with a dummy record or by using
a MapPartition function. Coming up with a good design for this is also part of this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message