flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #3054: [Flink 5404] Consolidate and update S3 documentati...
Date Thu, 05 Jan 2017 10:43:03 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3054#discussion_r94746683
  
    --- Diff: docs/setup/aws.md ---
    @@ -130,13 +134,13 @@ This registers `NativeS3FileSystem` as the default FileSystem for
URIs with the
     
     #### Hadoop Configuration
     
    -You can specify the [Hadoop configuration]({{ site.baseurl }}/setup/config.html#hdfs)
in various ways, for examples by configuring the path to the Hadoop configuration directory
in `flink-conf.yaml`:
    +You can specify the [Hadoop configuration]({{ site.baseurl }}/setup/config.html#hdfs)
in various ways, for example by configuring the path to the Hadoop configuration directory
in `flink-conf.yaml`:
     
     ```
     fs.hdfs.hadoopconf: /path/to/etc/hadoop
     ```
     
    -This registers `path/to/etc/hadoop` as Hadoop's configuration directory with Flink.
    +This registers `/path/to/etc/hadoop` as Hadoop's configuration directory with Flink.
Flink will look for the "core-site.xml" and "hdfs-site.xml" files in the specified directory.
 
    --- End diff --
    
    Reference to core-site.xml and hdfs-site.xml here uses double apostrophes, while \` is
used in other places.
    Lets keep that styling consistent here :) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message