flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #3036: [FLINK-5368] Log msg if kafka topic doesn't have a...
Date Thu, 05 Jan 2017 10:52:26 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3036#discussion_r94748197
  
    --- Diff: flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer09.java
---
    @@ -208,13 +208,12 @@ public FlinkKafkaConsumer09(List<String> topics, KeyedDeserializationSchema<T>
d
     				if (partitionsForTopic != null) {
     					partitions.addAll(convertToFlinkKafkaTopicPartition(partitionsForTopic));
     				}
    +				else{
    +					LOG.info("Unable to retrieve any partitions for the requested topic: {}", topic);
    +				}
     			}
     		}
     
    -		if (partitions.isEmpty()) {
    -			throw new RuntimeException("Unable to retrieve any partitions for the requested topics
" + topics);
    -		}
    --- End diff --
    
    I think we still want to fail if there are no partitions at all for ALL topics, correct?
    This change here will remove that behaviour.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message