flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request #3106: [FLINK-5118] Fix inconsistent numBytesIn/Out metri...
Date Thu, 12 Jan 2017 15:18:28 GMT
Github user uce commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializer.java
    @@ -99,7 +99,7 @@ public SerializationResult addRecord(T record) throws IOException {
     		this.lengthBuffer.putInt(0, len);
     		if (numBytesOut != null) {
    -			numBytesOut.inc(len);
    +			numBytesOut.inc(len + 4);
    --- End diff --
    I think this warrants both a comment and a test.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message