flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink issue #3133: [FLINK-5518] [input/output formats] Add null value check.
Date Tue, 17 Jan 2017 10:58:45 GMT
Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/3133
  
    Thanks for the PR @jakubhavlik.
    
    The fix looks good. Can you add a `testCloseWithoutOpen()` method to `org.apache.flink.api.java.hadoop.mapred.HadoopInputFormatTest`
and `org.apache.flink.api.java.hadoop.mapreduce.HadoopInputFormatTest` to guard this fix?
    
    Occasionally builds fail due to timeouts. That's nothing to worry about. I'll run the
tests again before merging.
    
    Thank you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message