flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3033: [FLINK-5256] Extend DataSetSingleRowJoin to suppor...
Date Wed, 18 Jan 2017 08:13:11 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3033#discussion_r96583281
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala
---
    @@ -46,6 +47,7 @@ class DataSetSingleRowJoin(
         rowRelDataType: RelDataType,
         joinCondition: RexNode,
         joinRowType: RelDataType,
    +    joinType: JoinRelType,
    --- End diff --
    
    You are right, the check in `DataSetSingleRowJoinRule` should already prevent this case.
However, I think it is good to have an alternative check here to be on the safe side. The
translation process might be changed be adding or modifying rules. So ideally, this check
will never trigger but if it catches something, this is a strong indication that the optimization
produced a wrong results.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message