flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #3026: [FLINK-2980] [table] Support for GROUPING SETS cla...
Date Mon, 23 Jan 2017 14:13:13 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3026#discussion_r97306898
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
    @@ -688,4 +726,37 @@ object array {
       }
     }
     
    +/**
    +  * Grouping function. Similar to a SQL GROUP_ID function.
    --- End diff --
    
    Please add the same description (with example) as in the documentation. `apply()` should
have the same description.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message