flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #3026: [FLINK-2980] [table] Support for GROUPING SETS cla...
Date Mon, 23 Jan 2017 14:13:13 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3026#discussion_r97314552
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/ExpressionParser.scala
---
    @@ -375,15 +393,26 @@ object ExpressionParser extends JavaTokenParsers with PackratParsers
{
       lazy val prefixFlattening: PackratParser[Expression] =
         FLATTEN ~ "(" ~> composite <~ ")" ^^ { e => Flattening(e) }
     
    +  lazy val prefixGrouping: PackratParser[Expression] =
    +    GROUPING ~ "(" ~> composite <~ ")" ^^ { e => Grouping(e) }
    +
    +  lazy val prefixGroupingId: PackratParser[Expression] =
    +    GROUPING_ID ~ "(" ~> repsep(expression, ",") <~ ")" ^^ { l => GroupingId(l:
_*) }
    +
    +  lazy val prefixGroupId: PackratParser[Expression] =
    +    GROUP_ID ~ opt("()") ^^ { _ => GroupId() }
    +
       lazy val prefixed: PackratParser[Expression] =
         prefixArray | prefixSum | prefixMin | prefixMax | prefixCount | prefixAvg |
    -      prefixStart | prefixEnd | prefixCast | prefixAs | prefixTrim | prefixTrimWithoutArgs
|
    -      prefixIf | prefixExtract | prefixFloor | prefixCeil | prefixGet | prefixFlattening
|
    +      prefixStart | prefixEnd |
    +      prefixCast | prefixAs | prefixTrim | prefixTrimWithoutArgs | prefixIf | prefixExtract
|
    +      prefixFloor | prefixCeil | prefixGet | prefixFlattening |
    +      prefixGroupingId | prefixGrouping | prefixGroupId |
           prefixFunctionCall | prefixFunctionCallOneArg // function call must always be at
the end
     
       // suffix/prefix composite
     
    -  lazy val composite: PackratParser[Expression] = suffixed | prefixed | atom |
    +  lazy val composite: PackratParser[Expression] = suffixed | prefixed | atom | grouped
|
    --- End diff --
    
    The `grouped` in `expression` should be enough. We don't need it here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message