flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #3026: [FLINK-2980] [table] Support for GROUPING SETS cla...
Date Mon, 23 Jan 2017 14:13:14 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3026#discussion_r97307329
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
    @@ -15,14 +15,17 @@
      * See the License for the specific language governing permissions and
      * limitations under the License.
      */
    +
     package org.apache.flink.table.api
     
     import org.apache.calcite.rel.RelNode
    +import org.apache.calcite.sql.SqlKind
    +import org.apache.calcite.tools.RelBuilder
     import org.apache.flink.api.common.typeinfo.TypeInformation
     import org.apache.flink.api.java.operators.join.JoinType
     import org.apache.flink.table.calcite.FlinkTypeFactory
    -import org.apache.flink.table.plan.logical.Minus
    -import org.apache.flink.table.expressions.{Alias, Asc, Call, Expression, ExpressionParser,
Ordering, TableFunctionCall, UnresolvedAlias}
    +import org.apache.flink.table.plan.logical.{Minus => MinusNode}
    +import org.apache.flink.table.expressions._
    --- End diff --
    
    Is this import and the renaming of Minus really necessary?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message