flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...
Date Wed, 25 Jan 2017 17:32:12 GMT
Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3191#discussion_r97822798
  
    --- Diff: docs/dev/windows.md ---
    @@ -278,38 +343,39 @@ input
     {% highlight scala %}
     val input: DataStream[T] = ...
     
    -// tumbling event-time windows
     input
         .keyBy(<key selector>)
    -    .window(TumblingEventTimeWindows.of(Time.days(1), Time.hours(-8)))
    +    .window(GlobalWindows.create())
         .<windowed transformation>(<window function>)
     {% endhighlight %}
     </div>
     </div>
     
    -## Window Functions
    +## Window Function
    --- End diff --
    
    All the other section headings for windowing components are pluralised, this one ist not.
We should keep it consistent and pluralise all or none.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message