flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rehevkor5 <...@git.apache.org>
Subject [GitHub] flink issue #3189: [FLINK-5608] [webfrontend] Cancel button stays visible in...
Date Wed, 25 Jan 2017 23:42:20 GMT
Github user rehevkor5 commented on the issue:

    https://github.com/apache/flink/pull/3189
  
    Thanks @uce that's helpful! Didn't think of putting screenshots in the PR.
    
    @zentol The global job state counts didn't seem like the most important thing to show
when the browser is narrow, given that this view is about a particular job. So, I added these
CSS classes to it ".hidden-xs .hidden-sm .hidden-md" the behavior of which is described on
http://getbootstrap.com/css/#responsive-utilities I am not sure what width @uce used for the
"wide" screenshots, but it probably was less than 1200px, otherwise it would show up. I can
remove the ".hidden-md" class if you want it to show up in the 992px to 1200px range, too...
however it does make it more likely for the other more job-specific elements (start/end, duration)
to wrap & get lost. Perhaps it would be a good idea to reorder the elements? Put start/end
& duration first, and overall job stats last so that it's the first one to wrap? Let me
know if you have a preference.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message