flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...
Date Thu, 26 Jan 2017 16:32:14 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3191#discussion_r98025666
  
    --- Diff: docs/dev/windows.md ---
    @@ -86,9 +101,10 @@ will be performed by a single task, *i.e.* with parallelism of 1.
     
     ## Window Assigners
     
    -After specifying whether your stream is keyed or not, the next step is to define a *windowing
strategy*. 
    -The windowing strategy defines how elements are assigned to windows. This is done by
specifying the 
    -`WindowAssigner` that corresponds to the windowing strategy of your choice in the `window(...)`
call. 
    +After specifying whether your stream is keyed or not, the next step is to define a *window
assigner*. 
    +The window assigner defines how elements are assigned to windows. This is done by specifying
the 
    +`WindowAssigner` that corresponds to the windowing strategy of your choice in the `window(...)`
(for *keyed* streams)
    --- End diff --
    
    "This is done by specifying the `WindowAssigner` of your choice in the `window(...)` ...",
i.e. remove "windowing strategy"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message