flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2980) Add CUBE/ROLLUP/GROUPING SETS operator in Table API.
Date Mon, 23 Jan 2017 14:13:27 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834600#comment-15834600
] 

ASF GitHub Bot commented on FLINK-2980:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3026#discussion_r97314552
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/ExpressionParser.scala
---
    @@ -375,15 +393,26 @@ object ExpressionParser extends JavaTokenParsers with PackratParsers
{
       lazy val prefixFlattening: PackratParser[Expression] =
         FLATTEN ~ "(" ~> composite <~ ")" ^^ { e => Flattening(e) }
     
    +  lazy val prefixGrouping: PackratParser[Expression] =
    +    GROUPING ~ "(" ~> composite <~ ")" ^^ { e => Grouping(e) }
    +
    +  lazy val prefixGroupingId: PackratParser[Expression] =
    +    GROUPING_ID ~ "(" ~> repsep(expression, ",") <~ ")" ^^ { l => GroupingId(l:
_*) }
    +
    +  lazy val prefixGroupId: PackratParser[Expression] =
    +    GROUP_ID ~ opt("()") ^^ { _ => GroupId() }
    +
       lazy val prefixed: PackratParser[Expression] =
         prefixArray | prefixSum | prefixMin | prefixMax | prefixCount | prefixAvg |
    -      prefixStart | prefixEnd | prefixCast | prefixAs | prefixTrim | prefixTrimWithoutArgs
|
    -      prefixIf | prefixExtract | prefixFloor | prefixCeil | prefixGet | prefixFlattening
|
    +      prefixStart | prefixEnd |
    +      prefixCast | prefixAs | prefixTrim | prefixTrimWithoutArgs | prefixIf | prefixExtract
|
    +      prefixFloor | prefixCeil | prefixGet | prefixFlattening |
    +      prefixGroupingId | prefixGrouping | prefixGroupId |
           prefixFunctionCall | prefixFunctionCallOneArg // function call must always be at
the end
     
       // suffix/prefix composite
     
    -  lazy val composite: PackratParser[Expression] = suffixed | prefixed | atom |
    +  lazy val composite: PackratParser[Expression] = suffixed | prefixed | atom | grouped
|
    --- End diff --
    
    The `grouped` in `expression` should be enough. We don't need it here.


> Add CUBE/ROLLUP/GROUPING SETS operator in Table API.
> ----------------------------------------------------
>
>                 Key: FLINK-2980
>                 URL: https://issues.apache.org/jira/browse/FLINK-2980
>             Project: Flink
>          Issue Type: New Feature
>          Components: Documentation, Table API & SQL
>            Reporter: Chengxiang Li
>            Assignee: Alexander Chermenin
>         Attachments: Cube-Rollup-GroupSet design doc in Flink.pdf
>
>
> Computing aggregates over a cube/rollup/grouping sets of several dimensions is a common
operation in data warehousing. It would be nice to have them in Table API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message