flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2980) Add CUBE/ROLLUP/GROUPING SETS operator in Table API.
Date Mon, 23 Jan 2017 14:13:29 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834611#comment-15834611
] 

ASF GitHub Bot commented on FLINK-2980:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3026#discussion_r97317694
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/groupings.scala
---
    @@ -0,0 +1,138 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.expressions
    +
    +import org.apache.calcite.tools.RelBuilder
    +import org.apache.flink.api.common.typeinfo.BasicTypeInfo
    +
    +abstract sealed class GroupFunction extends Expression {
    +
    +  override def toString = s"GroupFunction($children)"
    +
    +  private[flink] def replaceExpression(
    --- End diff --
    
    Can you add a Scaladoc here (esp. for the parameters)? Please also add some line comments
in this method to improve readability.


> Add CUBE/ROLLUP/GROUPING SETS operator in Table API.
> ----------------------------------------------------
>
>                 Key: FLINK-2980
>                 URL: https://issues.apache.org/jira/browse/FLINK-2980
>             Project: Flink
>          Issue Type: New Feature
>          Components: Documentation, Table API & SQL
>            Reporter: Chengxiang Li
>            Assignee: Alexander Chermenin
>         Attachments: Cube-Rollup-GroupSet design doc in Flink.pdf
>
>
> Computing aggregates over a cube/rollup/grouping sets of several dimensions is a common
operation in data warehousing. It would be nice to have them in Table API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message