flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2980) Add CUBE/ROLLUP/GROUPING SETS operator in Table API.
Date Mon, 23 Jan 2017 14:13:30 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834623#comment-15834623
] 

ASF GitHub Bot commented on FLINK-2980:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3026#discussion_r97320762
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
    @@ -94,7 +94,24 @@ case class Project(projectList: Seq[NamedExpression], child: LogicalNode)
extend
       override protected[logical] def construct(relBuilder: RelBuilder): RelBuilder = {
         child.construct(relBuilder)
         relBuilder.project(
    -      projectList.map(_.toRexNode(relBuilder)).asJava,
    +      projectList.map {
    --- End diff --
    
    I think this translation should rather happen in `resolveExpression` and needs to be reworked
a bit. E.g. `groupId() as 'a as 'f` fails. Some inline comments would also be very good.


> Add CUBE/ROLLUP/GROUPING SETS operator in Table API.
> ----------------------------------------------------
>
>                 Key: FLINK-2980
>                 URL: https://issues.apache.org/jira/browse/FLINK-2980
>             Project: Flink
>          Issue Type: New Feature
>          Components: Documentation, Table API & SQL
>            Reporter: Chengxiang Li
>            Assignee: Alexander Chermenin
>         Attachments: Cube-Rollup-GroupSet design doc in Flink.pdf
>
>
> Computing aggregates over a cube/rollup/grouping sets of several dimensions is a common
operation in data warehousing. It would be nice to have them in Table API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message