flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3475) DISTINCT aggregate function support for SQL queries
Date Tue, 17 Jan 2017 01:23:27 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15824818#comment-15824818
] 

ASF GitHub Bot commented on FLINK-3475:
---------------------------------------

Github user KurtYoung commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3111#discussion_r96329552
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/FlinkRuleSets.scala
---
    @@ -96,6 +96,13 @@ object FlinkRuleSets {
         ProjectToCalcRule.INSTANCE,
         CalcMergeRule.INSTANCE,
     
    +    // distinct aggregate rule for FLINK-3475
    --- End diff --
    
    I think this comment can move to `FlinkAggregateExpandDistinctAggregatesRule`, and open
a jira to track to remove this class after we upgrade Calcite.


> DISTINCT aggregate function support for SQL queries
> ---------------------------------------------------
>
>                 Key: FLINK-3475
>                 URL: https://issues.apache.org/jira/browse/FLINK-3475
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Chengxiang Li
>            Assignee: Zhenghua Gao
>
> DISTINCT aggregate function may be able to reuse the aggregate function instead of separate
implementation, and let Flink runtime take care of duplicate records.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message