flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3475) DISTINCT aggregate function support for SQL queries
Date Wed, 18 Jan 2017 05:04:26 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15827429#comment-15827429
] 

ASF GitHub Bot commented on FLINK-3475:
---------------------------------------

Github user docete commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3111#discussion_r96568191
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/AggregationTest.scala
---
    @@ -165,9 +165,13 @@ class AggregationTest extends TableTestBase {
         val util = batchTestUtil()
         val sourceTable = util.addTable[(Int, Long, Int)]("MyTable", 'a, 'b, 'c)
     
    -    val resultTable = sourceTable.groupBy('a)
    +    // Move "where" before "groupBy" for the former query would generate
    +    // nondeterministic plans with same cost. If we change FlinkRuleSets.DATASET_OPT_RULES,
    +    // the importance of relNode may change, and the test may fail. This issue is mentioned
    +    // in FLINK-5394, we could move "where" to the end when FLINK-5394 is fixed.
    +    val resultTable = sourceTable.where('a === 1).groupBy('a)
    --- End diff --
    
    I will check the finish time for #3058 with @beyond1920 


> DISTINCT aggregate function support for SQL queries
> ---------------------------------------------------
>
>                 Key: FLINK-3475
>                 URL: https://issues.apache.org/jira/browse/FLINK-3475
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Chengxiang Li
>            Assignee: Zhenghua Gao
>
> DISTINCT aggregate function may be able to reuse the aggregate function instead of separate
implementation, and let Flink runtime take care of duplicate records.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message