flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5160) SecurityContextTest#testCreateInsecureHadoopCtx fails on windows
Date Thu, 05 Jan 2017 14:52:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15801558#comment-15801558
] 

ASF GitHub Bot commented on FLINK-5160:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/3066

    [FLINK-5160] [refactor] SecurityUtils use OperatingSystem.getCurrentOperatingSys…

    This is a follow-up refactoring to #2888 proposed by @StephanEwen .
    
    It changes the `SecurityUtils#getOSUserName` method to use no longer parse the OS name
itself but instead rely on the `OperatingSystem.getCurrentOperatingSystem` utility method.
    
    The `OperatingSystem` enum had to be extended to include the Solaris OS since the affected
code had a branch for it. The parsing for it was simply copied.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 5160_follow_up

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3066.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3066
    
----
commit 7b635f7504146871818453961c1d441b55b175a2
Author: zentol <chesnay@apache.org>
Date:   2017-01-05T14:39:25Z

    [FLINK-5160] SecurityUtils use OperatingSystem.getCurrentOperatingSystem()

----


> SecurityContextTest#testCreateInsecureHadoopCtx fails on windows
> ----------------------------------------------------------------
>
>                 Key: FLINK-5160
>                 URL: https://issues.apache.org/jira/browse/FLINK-5160
>             Project: Flink
>          Issue Type: Bug
>          Components: Security, Tests
>    Affects Versions: 1.1.3
>         Environment: Windows 10
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.2.0
>
>
> The test uses the wrong method to retrieve the current user name when run on Windows.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message