flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5464) MetricQueryService throws NullPointerException on JobManager
Date Mon, 23 Jan 2017 14:27:26 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834654#comment-15834654
] 

ASF GitHub Bot commented on FLINK-5464:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3128#discussion_r97327512
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDumpSerialization.java
---
    @@ -191,62 +233,65 @@ private static void serializeMeter(DataOutputStream dos, Meter meter)
throws IOE
     		 *
     		 * @param data serialized metrics
     		 * @return A list containing the deserialized metrics.
    -		 * @throws IOException
     		 */
    -		public List<MetricDump> deserialize(byte[] data) throws IOException {
    -			ByteArrayInputStream bais = new ByteArrayInputStream(data);
    -			DataInputStream dis = new DataInputStream(bais);
     
    -			int numCounters = dis.readInt();
    -			int numGauges = dis.readInt();
    -			int numHistograms = dis.readInt();
    -			int numMeters = dis.readInt();
    +		public List<MetricDump> deserialize(MetricDumpSerialization.MetricSerializationResult
data) {
    +			DataInputView in = new DataInputDeserializer(data.data, 0, data.data.length);
     
    -			List<MetricDump> metrics = new ArrayList<>(numCounters + numGauges + numHistograms);
    +			List<MetricDump> metrics = new ArrayList<>(data.numCounters + data.numGauges
+ data.numHistograms + data.numMeters);
     
    -			for (int x = 0; x < numCounters; x++) {
    -				metrics.add(deserializeCounter(dis));
    +			for (int x = 0; x < data.numCounters; x++) {
    +				try {
    +					metrics.add(deserializeCounter(in));
    +				} catch (Exception e) {
    +					LOG.warn("Failed to deserialize counter.", e);
    +				}
     			}
     
    -			for (int x = 0; x < numGauges; x++) {
    -				metrics.add(deserializeGauge(dis));
    +			for (int x = 0; x < data.numGauges; x++) {
    +				try {
    +					metrics.add(deserializeGauge(in));
    +				} catch (Exception e) {
    +					LOG.warn("Failed to deserialize counter.", e);
    +				}
     			}
     
    -			for (int x = 0; x < numHistograms; x++) {
    -				metrics.add(deserializeHistogram(dis));
    +			for (int x = 0; x < data.numHistograms; x++) {
    +				try {
    +					metrics.add(deserializeHistogram(in));
    +				} catch (Exception e) {
    +					LOG.warn("Failed to deserialize counter.", e);
    +				}
     			}
     
    -			for (int x = 0; x < numMeters; x++) {
    -				metrics.add(deserializeMeter(dis));
    +			for (int x = 0; x < data.numMeters; x++) {
    +				try {
    +					metrics.add(deserializeMeter(in));
    +				} catch (Exception e) {
    +					LOG.warn("Failed to deserialize counter.", e);
    +				}
     			}
    -
    -			return metrics;
    --- End diff --
    
    It appears i forgot to push some of the last-minute fixes :/


> MetricQueryService throws NullPointerException on JobManager
> ------------------------------------------------------------
>
>                 Key: FLINK-5464
>                 URL: https://issues.apache.org/jira/browse/FLINK-5464
>             Project: Flink
>          Issue Type: Bug
>          Components: Webfrontend
>    Affects Versions: 1.2.0
>            Reporter: Robert Metzger
>            Assignee: Chesnay Schepler
>
> I'm using Flink 699f4b0.
> My JobManager log contains many of these log entries:
> {code}
> 2017-01-11 19:42:05,778 WARN  org.apache.flink.runtime.webmonitor.metrics.MetricFetcher
    - Fetching metrics failed.
> akka.pattern.AskTimeoutException: Ask timed out on [Actor[akka://flink/user/MetricQueryService#-970662317]]
after [10000 ms]
> 	at akka.pattern.PromiseActorRef$$anonfun$1.apply$mcV$sp(AskSupport.scala:334)
> 	at akka.actor.Scheduler$$anon$7.run(Scheduler.scala:117)
> 	at scala.concurrent.Future$InternalCallbackExecutor$.scala$concurrent$Future$InternalCallbackExecutor$$unbatchedExecute(Future.scala:694)
> 	at scala.concurrent.Future$InternalCallbackExecutor$.execute(Future.scala:691)
> 	at akka.actor.LightArrayRevolverScheduler$TaskHolder.executeTask(Scheduler.scala:474)
> 	at akka.actor.LightArrayRevolverScheduler$$anon$8.executeBucket$1(Scheduler.scala:425)
> 	at akka.actor.LightArrayRevolverScheduler$$anon$8.nextTick(Scheduler.scala:429)
> 	at akka.actor.LightArrayRevolverScheduler$$anon$8.run(Scheduler.scala:381)
> 	at java.lang.Thread.run(Thread.java:745)
> 2017-01-11 19:42:07,765 WARN  org.apache.flink.runtime.metrics.dump.MetricQueryService
     - An exception occurred while processing a message.
> java.lang.NullPointerException
> 	at org.apache.flink.runtime.metrics.dump.MetricDumpSerialization.serializeGauge(MetricDumpSerialization.java:162)
> 	at org.apache.flink.runtime.metrics.dump.MetricDumpSerialization.access$300(MetricDumpSerialization.java:47)
> 	at org.apache.flink.runtime.metrics.dump.MetricDumpSerialization$MetricDumpSerializer.serialize(MetricDumpSerialization.java:90)
> 	at org.apache.flink.runtime.metrics.dump.MetricQueryService.onReceive(MetricQueryService.java:109)
> 	at akka.actor.UntypedActor$$anonfun$receive$1.applyOrElse(UntypedActor.scala:167)
> 	at akka.actor.Actor$class.aroundReceive(Actor.scala:467)
> 	at akka.actor.UntypedActor.aroundReceive(UntypedActor.scala:97)
> 	at akka.actor.ActorCell.receiveMessage(ActorCell.scala:516)
> 	at akka.actor.ActorCell.invoke(ActorCell.scala:487)
> 	at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:238)
> 	at akka.dispatch.Mailbox.run(Mailbox.scala:220)
> 	at akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(AbstractDispatcher.scala:397)
> 	at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
> 	at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
> 	at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
> 	at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message