flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5466) Make production environment default in gulpfile
Date Thu, 12 Jan 2017 09:52:51 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15820615#comment-15820615
] 

ASF GitHub Bot commented on FLINK-5466:
---------------------------------------

GitHub user uce opened a pull request:

    https://github.com/apache/flink/pull/3100

    [FLINK-5466] [webfrontend] Set environment to production in gulpfile

    The default environment was set to `development`, which leads to very large generated
JS files. When building the web UI we apparently forgot to set the environment to `production`
(build via `gulp production`).
    
    Since this is likely to occur again, I set the default environment to `production` and
let users set the environment to `development` manually (via `gulp dev`).
    
    Now:
    ```
    -rw-r--r--  1 uce  staff    42K Jan 12 10:43 index.js
    -rw-r--r--  1 uce  staff   931K Jan 12 10:43 vendor.js
    ```
    
    Before:
    ```
    -rw-r--r--  1 uce  staff   328K Jan 12 10:49 index.js
    -rw-r--r--  1 uce  staff   8.4M Jan 12 10:49 vendor.js
    ```
    
    I would like to merge this to the 1.1 and 1.2 branches as well.
    
    /cc @joerg84


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/flink 5466-prod

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3100.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3100
    
----
commit bd666810aa2df86206b607199139dedb23910b84
Author: Ufuk Celebi <uce@apache.org>
Date:   2017-01-12T09:46:31Z

    [FLINK-5466] [webfrontend] Set environment to production in gulpfile

----


> Make production environment default in gulpfile
> -----------------------------------------------
>
>                 Key: FLINK-5466
>                 URL: https://issues.apache.org/jira/browse/FLINK-5466
>             Project: Flink
>          Issue Type: Improvement
>          Components: Webfrontend
>    Affects Versions: 1.2.0, 1.1.4
>            Reporter: Ufuk Celebi
>
> Currently the default environment set in our gulpfile is development, which lead to very
large created JS files. When building the web UI we apparently forgot to set the environment
to production (build via gulp production).
> Since this is likely to occur again, we should make the default environment production
and make sure to use development manually.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message