flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5520) Disable outer joins with non-equality predicates
Date Wed, 18 Jan 2017 04:38:27 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15827414#comment-15827414
] 

ASF GitHub Bot commented on FLINK-5520:
---------------------------------------

Github user lincoln-lil commented on the issue:

    https://github.com/apache/flink/pull/3141
  
    Hi, wuchong, thanks for your review. I'll switch the pr based on 1.2.0.
    I think it's not necessary doing validation repeatedly both in DataSetJoinRule.java and
operators.scala, and there already being several validations in DataSetJoin.translateToPlan
function, why don't we put the same validation together to reduce code?


> Disable outer joins with non-equality predicates
> ------------------------------------------------
>
>                 Key: FLINK-5520
>                 URL: https://issues.apache.org/jira/browse/FLINK-5520
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Fabian Hueske
>            Assignee: lincoln.lee
>            Priority: Blocker
>             Fix For: 1.2.0
>
>
> Outer joins with non-equality predicates (and at least one equality predicate) compute
incorrect results. 
> Since this is not a very common requirement, I propose to disable this feature for the
1.2.0 release and correctly implement it for a later version.
> The fix should add checks in the Table API validation phase (to get a good error message)
and in the DataSetJoinRule to prevent translation of SQL queries with non-equality predicates
on outer joins.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message