flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5520) Disable outer joins with non-equality predicates
Date Thu, 19 Jan 2017 13:19:27 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829901#comment-15829901
] 

ASF GitHub Bot commented on FLINK-5520:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3141#discussion_r96843797
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/JoinITCase.scala
---
    @@ -375,4 +395,62 @@ class JoinITCase(
     
         Assert.assertEquals(0, result)
       }
    +
    +  @Test(expected = classOf[TableException])
    +  def testRightOuterJoinWithNonEquiJoinPredicate(): Unit = {
    +
    +    val env = ExecutionEnvironment.getExecutionEnvironment
    +    val tEnv = TableEnvironment.getTableEnvironment(env, config)
    +    tEnv.getConfig.setNullCheck(true)
    +
    +    val sqlQuery = "SELECT c, g FROM Table3 RIGHT OUTER JOIN Table5 ON b = e and a >
d"
    +
    +    val ds1 = CollectionDataSets.getSmall3TupleDataSet(env).toTable(tEnv).as('a, 'b,
'c)
    +    val ds2 = CollectionDataSets.get5TupleDataSet(env).toTable(tEnv).as('d, 'e, 'f, 'g,
'h)
    +    tEnv.registerTable("Table3", ds1)
    +    tEnv.registerTable("Table5", ds2)
    +
    +    tEnv.sql(sqlQuery).toDataSet[Row].collect()
    +
    +    val results = tEnv.sql(sqlQuery).toDataSet[Row].collect()
    --- End diff --
    
    This line can be removed


> Disable outer joins with non-equality predicates
> ------------------------------------------------
>
>                 Key: FLINK-5520
>                 URL: https://issues.apache.org/jira/browse/FLINK-5520
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Fabian Hueske
>            Assignee: lincoln.lee
>            Priority: Blocker
>             Fix For: 1.2.0
>
>
> Outer joins with non-equality predicates (and at least one equality predicate) compute
incorrect results. 
> Since this is not a very common requirement, I propose to disable this feature for the
1.2.0 release and correctly implement it for a later version.
> The fix should add checks in the Table API validation phase (to get a good error message)
and in the DataSetJoinRule to prevent translation of SQL queries with non-equality predicates
on outer joins.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message